Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to /usr/bin/env sh for portability #1072

Merged
merged 1 commit into from Jan 29, 2016
Merged

Conversation

@tony
Copy link
Contributor

tony commented Jan 25, 2016

See also: #1069

There are other scripts (configure_travis.sh and src/run-tests.sh in libpypa upstream). Need to get a Ubuntu system up to double check they wouldn't break (they would if there we bash-specific code in it)

See also: #1069
@tony
Copy link
Contributor Author

tony commented Jan 28, 2016

Works on Ubuntu

@kmod
Copy link
Collaborator

kmod commented Jan 29, 2016

Looks good to me -- please sign our CLA and then I'll merge it :)

@tony
Copy link
Contributor Author

tony commented Jan 29, 2016

Done

kmod added a commit that referenced this pull request Jan 29, 2016
Switch to /usr/bin/env sh for portability
@kmod kmod merged commit 523ecd6 into dropbox:master Jan 29, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmod
Copy link
Collaborator

kmod commented Jan 29, 2016

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.