New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to /usr/bin/env sh for portability #1072

Merged
merged 1 commit into from Jan 29, 2016

Conversation

Projects
None yet
2 participants
@tony
Contributor

tony commented Jan 25, 2016

See also: #1069

There are other scripts (configure_travis.sh and src/run-tests.sh in libpypa upstream). Need to get a Ubuntu system up to double check they wouldn't break (they would if there we bash-specific code in it)

@tony

This comment has been minimized.

Show comment
Hide comment
@tony

tony Jan 28, 2016

Contributor

Works on Ubuntu

Contributor

tony commented Jan 28, 2016

Works on Ubuntu

@kmod

This comment has been minimized.

Show comment
Hide comment
@kmod

kmod Jan 29, 2016

Collaborator

Looks good to me -- please sign our CLA and then I'll merge it :)

Collaborator

kmod commented Jan 29, 2016

Looks good to me -- please sign our CLA and then I'll merge it :)

@tony

This comment has been minimized.

Show comment
Hide comment
@tony

tony Jan 29, 2016

Contributor

Done

Contributor

tony commented Jan 29, 2016

Done

kmod added a commit that referenced this pull request Jan 29, 2016

Merge pull request #1072 from tony/remove-bashisms
Switch to /usr/bin/env sh for portability

@kmod kmod merged commit 523ecd6 into dropbox:master Jan 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmod

This comment has been minimized.

Show comment
Hide comment
@kmod

kmod Jan 29, 2016

Collaborator

Awesome, thanks!

Collaborator

kmod commented Jan 29, 2016

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment