Fix for calc_bruteforce_cardinality #6

Merged
merged 1 commit into from Aug 1, 2012

Conversation

Projects
None yet
2 participants
Contributor

tekul commented Jun 10, 2012

The function was overestimating the cardinality
for upper-case characters and digits by mistakenly
identifying them as symbols. Thus a simple repeat
sequence like "AAAAAA" would have cardinality
26+33=59 rather than 26.

@tekul tekul Fix calc_bruteforce_cardinality
The function was overestimating the cardinality
for upper-case characters and digits by mistakenly
identifying them as symbols. Thus a simple repeat
sequence like "AAAAAA" would have cardinality
26+33=59 rather than 26.
c753c80
Collaborator

lowe commented Aug 1, 2012

nice catch, and apologies for waiting two months on a bugfix. i've been out of the country.

@lowe lowe added a commit that referenced this pull request Aug 1, 2012

@lowe lowe Merge pull request #6 from tekul/master
Fix for calc_bruteforce_cardinality
d8fc9c0

@lowe lowe merged commit d8fc9c0 into dropbox:master Aug 1, 2012

Contributor

tekul commented Aug 1, 2012

Thanks, yes - I got your "gone camping" auto-response :-). Did you get the email I sent you about my port?

Collaborator

lowe commented Aug 1, 2012

Hey tekul, just searched my inbox, I don't think I did.

On 1 August 2012 06:33, tekul
reply@reply.github.com
wrote:

Thanks, yes - I got your "gone camping" auto-response :-). Did you get the email I sent you about my port?


Reply to this email directly or view it on GitHub:
lowe#6 (comment)

Contributor

tekul commented Aug 2, 2012

OK, I sent it again. Just wanted to check about licensing and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment