Skip to content

Commit 48d850c

Browse files
committed
Drop redundant single-column indexes shadowed by unique constraints
Removes five `Index(fields=["x"])` declarations whose columns are already covered by a same-column `UniqueConstraint`. The unique-backed btree handles the same lookups and enforces uniqueness, so the extra non-unique index was pure write-side overhead with no read benefit. - plainjobs_jobrequest: drop uuid_idx (covered by *_unique_uuid) - plainjobs_jobprocess: drop uuid_idx (covered by *_unique_uuid) - plainjobs_jobresult: drop uuid_idx and job_process_uuid_idx - plainobserver_trace: drop trace_id_idx (covered by observer_unique_trace_id) Surfaced by the upgraded `postgres.duplicate_indexes` check.
1 parent 253513b commit 48d850c

2 files changed

Lines changed: 0 additions & 10 deletions

File tree

plain-jobs/plain/jobs/models.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ class JobRequest(postgres.Model):
113113
postgres.Index(
114114
name="plainjobs_jobrequest_trace_id_idx", fields=["trace_id"]
115115
),
116-
postgres.Index(name="plainjobs_jobrequest_uuid_idx", fields=["uuid"]),
117116
# Used for job grouping queries
118117
postgres.Index(
119118
name="job_request_concurrency_key",
@@ -231,7 +230,6 @@ class JobProcess(postgres.Model):
231230
postgres.Index(
232231
name="plainjobs_jobprocess_trace_id_idx", fields=["trace_id"]
233232
),
234-
postgres.Index(name="plainjobs_jobprocess_uuid_idx", fields=["uuid"]),
235233
postgres.Index(
236234
name="plainjobs_jobprocess_worker_id_idx", fields=["worker_id"]
237235
),
@@ -648,10 +646,6 @@ class JobResult(postgres.Model):
648646
postgres.Index(
649647
name="plainjobs_jobresult_created_at_idx", fields=["created_at"]
650648
),
651-
postgres.Index(
652-
name="plainjobs_jobresult_job_process_uuid_idx",
653-
fields=["job_process_uuid"],
654-
),
655649
postgres.Index(
656650
name="plainjobs_jobresult_started_at_idx", fields=["started_at"]
657651
),
@@ -670,7 +664,6 @@ class JobResult(postgres.Model):
670664
postgres.Index(
671665
name="plainjobs_jobresult_trace_id_idx", fields=["trace_id"]
672666
),
673-
postgres.Index(name="plainjobs_jobresult_uuid_idx", fields=["uuid"]),
674667
],
675668
constraints=[
676669
postgres.UniqueConstraint(

plain-observer/plain/observer/models.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,6 @@ class Trace(postgres.Model):
7979
)
8080
],
8181
indexes=[
82-
postgres.Index(
83-
name="plainobserver_trace_trace_id_idx", fields=["trace_id"]
84-
),
8582
postgres.Index(
8683
name="plainobserver_trace_start_time_idx", fields=["start_time"]
8784
),

0 commit comments

Comments
 (0)