Test database backends in CI (#48)

Author: davegaeddert

.github/workflows/test.yml

@@ -1,11 +1,39 @@
 name: test
 on:
-  push: {}
   pull_request: {}
+  push:
+    branches:
+      - master
 
 jobs:
   test:
     runs-on: ubuntu-latest
+    services:
+      postgres:
+        image: postgres:16
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: postgres
+          POSTGRES_DB: plain
+        ports:
+          - 5432:5432
+        options: >-
+          --health-cmd="pg_isready -U postgres"
+          --health-interval=10s
+          --health-timeout=5s
+          --health-retries=5
+      mysql:
+        image: mysql:8
+        env:
+          MYSQL_ROOT_PASSWORD: mysql
+          MYSQL_DATABASE: plain
+        ports:
+          - 3306:3306
+        options: >-
+          --health-cmd="mysqladmin ping -h localhost -u root --password=mysql"
+          --health-interval=10s
+          --health-timeout=5s
+          --health-retries=5
     strategy:
       matrix:
         python-version: ["3.11", "3.12", "3.13"]
@@ -16,8 +44,25 @@ jobs:
       uses: astral-sh/setup-uv@v2
     - name: Set up Python
       run: uv python install ${{ matrix.python-version }}
-    - name: Run tests
+    - name: Install system libraries for MySQL client build
+      run: |
+        sudo apt-get update -y
+        sudo apt-get install -y default-libmysqlclient-dev build-essential pkg-config
+
+    - name: Test (SQLite)
+      run: ./scripts/test
+      env:
+        DATABASE_URL: "sqlite://:memory:"
+
+    - name: Test (PostgreSQL)
+      run: ./scripts/test
+      env:
+        DATABASE_URL: postgres://postgres:postgres@localhost:5432/plain
+
+    - name: Test (MySQL)
       run: ./scripts/test
+      env:
+        DATABASE_URL: mysql://root:mysql@127.0.0.1:3306/plain
 
   lint:
     runs-on: ubuntu-latest

demos/full/app/settings.py

@@ -28,11 +28,6 @@
 SUPPORT_EMAIL = "support@example.com"
 OAUTH_LOGIN_PROVIDERS = {}
 
-DATABASE = {
-    "ENGINE": "plain.models.backends.sqlite3",
-    "NAME": ":memory:",
-}
-
 MIDDLEWARE = [
     "plain.sessions.middleware.SessionMiddleware",
     "plain.auth.middleware.AuthenticationMiddleware",

demos/full/test_urls.py renamed to demos/full/tests/test_urls.py

@@ -9,10 +9,7 @@
     "plain.admin",
     "app.users",
 ]
-DATABASE = {
-    "ENGINE": "plain.models.backends.sqlite3",
-    "NAME": ":memory:",
-}
+
 MIDDLEWARE = [
     "plain.sessions.middleware.SessionMiddleware",
     "plain.auth.middleware.AuthenticationMiddleware",

plain-admin/tests/app/settings.py

@@ -6,10 +6,6 @@
     "plain.models",
     "app.users",
 ]
-DATABASE = {
-    "ENGINE": "plain.models.backends.sqlite3",
-    "NAME": ":memory:",
-}
 MIDDLEWARE = [
     "plain.sessions.middleware.SessionMiddleware",
     "plain.auth.middleware.AuthenticationMiddleware",

plain-auth/tests/app/settings.py

@@ -12,7 +12,6 @@ dependencies = [
     "python-dotenv~=1.0.0",
     "gunicorn>20",
     "requests>=2.0.0",
-    "psycopg[binary]~=3.2.2",
     "rich",
     "inotify",
 ]

plain-dev/pyproject.toml

@@ -4,7 +4,3 @@
     "plain.models",
     "plain.flags",
 ]
-DATABASE = {
-    "ENGINE": "plain.models.backends.sqlite3",
-    "NAME": ":memory:",
-}

plain-flags/tests/app/settings.py

@@ -6,23 +6,16 @@
 
 from functools import cached_property
 
+import MySQLdb as Database
+from MySQLdb.constants import CLIENT, FIELD_TYPE
+from MySQLdb.converters import conversions
+
 from plain.exceptions import ImproperlyConfigured
 from plain.models.backends import utils as backend_utils
 from plain.models.backends.base.base import BaseDatabaseWrapper
 from plain.models.db import IntegrityError
 from plain.utils.regex_helper import _lazy_re_compile
 
-try:
-    import MySQLdb as Database
-except ImportError as err:
-    raise ImproperlyConfigured(
-        "Error loading MySQLdb module.\nDid you install mysqlclient?"
-    ) from err
-
-from MySQLdb.constants import CLIENT, FIELD_TYPE
-from MySQLdb.converters import conversions
-
-# Some of these import MySQLdb, so import them after checking if it's installed.
 from .client import DatabaseClient
 from .creation import DatabaseCreation
 from .features import DatabaseFeatures
@@ -31,13 +24,6 @@
 from .schema import DatabaseSchemaEditor
 from .validation import DatabaseValidation
 
-version = Database.version_info
-if version < (1, 4, 3):
-    raise ImproperlyConfigured(
-        f"mysqlclient 1.4.3 or newer is required; you have {Database.__version__}."
-    )
-
-
 # MySQLdb returns TIME columns as timedelta -- they are more like timedelta in
 # terms of actual behavior as they are signed and include days -- and Plain
 # expects time.

plain-models/plain/models/backends/mysql/base.py

@@ -1,6 +1,8 @@
 from plain.models.backends.base.schema import BaseDatabaseSchemaEditor
 from plain.models.constants import LOOKUP_SEP
-from plain.models.fields import NOT_PROVIDED, F, UniqueConstraint
+from plain.models.constraints import UniqueConstraint
+from plain.models.expressions import F
+from plain.models.fields import NOT_PROVIDED
 
 
 class DatabaseSchemaEditor(BaseDatabaseSchemaEditor):

plain-models/plain/models/backends/mysql/schema.py

@@ -47,10 +47,13 @@ class ChildSetNull(models.Model):
 
 @models.register_model
 class ChildSetDefault(models.Model):
+    def default_parent_pk():
+        return DeleteParent.objects.get(name="default").pk
+
     parent = models.ForeignKey(
         DeleteParent,
         on_delete=models.SET_DEFAULT,
-        default=1,
+        default=default_parent_pk,
     )