New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer DNS resolution in GraphiteReporter #1004

Merged
merged 1 commit into from Apr 22, 2015

Conversation

Projects
None yet
2 participants
@arteam
Member

arteam commented Apr 21, 2015

InetSockedAddres performs DNS resolution during construction time, which is not great if the Graphite server moves to a different IP-address.

The solution is to initialize Graphite gateway with a hostname and port. In such configuration it will resolve an address just before connecting to the server.

Resolve #1003

Defer DNS resolution in GraphiteReporter
InetSockedAddress performs DNS resolution during
construction time, which is not great if the Graphite server
moves to a different IP-address.

The solution is to initialize Graphite gateway with a hostname
and port. In such configuration it will resolve an address just
before connecting to the server.

Resolve #1003
@joschi

This comment has been minimized.

Member

joschi commented Apr 22, 2015

LGTM! 👍

joschi added a commit that referenced this pull request Apr 22, 2015

Merge pull request #1004 from arteam/graphite_correct_dns
Defer DNS resolution in GraphiteReporter

@joschi joschi merged commit f7fc30b into dropwizard:master Apr 22, 2015

@joschi joschi added this to the 0.9.0 milestone Apr 22, 2015

@arteam arteam added the improvement label Apr 26, 2015

@arteam arteam deleted the arteam:graphite_correct_dns branch Jan 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment