New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1157 Fixed user modifications of 'User-Agent' http header on requests #1198

Merged
merged 6 commits into from Aug 13, 2015

Conversation

Projects
None yet
3 participants
@kkrushnyakov

kkrushnyakov commented Jul 30, 2015

The details are here:
#1157
https://groups.google.com/forum/#!topic/dropwizard-user/XmSTpzz8Xx8

This commit is a part of UpWork.com initiative to maintain the 0.8.x
branch. The details about it are here:
https://groups.google.com/forum/#!topic/dropwizard-dev/hlK_Wi_2jis

/**
* Prevents Jersey from modification Request's User-Agent header with default value, to escape the value conflict with Dropwizard
*
* @author kirillkrushnyakov@cloud.upwork.com

This comment has been minimized.

@jplock

jplock Jul 30, 2015

Member

Please remove the @author line

This comment has been minimized.

@kkrushnyakov
* @author kirillkrushnyakov@cloud.upwork.com
*
*/

This comment has been minimized.

@jplock

jplock Jul 30, 2015

Member

Do you need a @Provider annotation?

This comment has been minimized.

@kkrushnyakov

Kirill Krushnyakov added some commits Jul 30, 2015

Kirill Krushnyakov
#1157 Fixed user modifications of 'User-Agent' http header on requests
Fixed annotations and javadocs after previous PR

The issue details are here:
#1157
https://groups.google.com/forum/#!topic/dropwizard-user/XmSTpzz8Xx8

This commit is a part of UpWork.com initiative to maintain the 0.8.x
branch. The details about it are here:
https://groups.google.com/forum/#!topic/dropwizard-dev/hlK_Wi_2jis
Kirill Krushnyakov
#1157 Fixed user modifications of 'User-Agent' http header on requests
Fixed annotations and javadocs after previous PR

The issue details are here:
#1157
https://groups.google.com/forum/#!topic/dropwizard-user/XmSTpzz8Xx8

This commit is a part of UpWork.com initiative to maintain the 0.8.x
branch. The details about it are here:
https://groups.google.com/forum/#!topic/dropwizard-dev/hlK_Wi_2jis
@jplock

This comment has been minimized.

Member

jplock commented Aug 3, 2015

Sorry one last thing, can you please use 4 spaces for indentation instead of tabs? It looks like tabs in the PR.

@jplock

This comment has been minimized.

Member

jplock commented Aug 3, 2015

Is there anyway to provide a test for this so its not broken in the future?

@joschi joschi added this to the 0.8.3 milestone Aug 13, 2015

@joschi

This comment has been minimized.

Member

joschi commented Aug 13, 2015

LGTM. Thanks for adding the test cases!

joschi added a commit that referenced this pull request Aug 13, 2015

Merge pull request #1198 from kkrushnyakov/user_agent_http_header_patch
Fixed user modifications of 'User-Agent' http header on requests

Closes #1157

@joschi joschi merged commit 5a0a0a2 into dropwizard:release/0.8.x Aug 13, 2015

@joschi joschi added the bug label Aug 13, 2015

joschi added a commit that referenced this pull request Aug 13, 2015

Merge pull request #1198 from kkrushnyakov/user_agent_http_header_patch
Fixed user modifications of 'User-Agent' http header on requests

Closes #1157
(cherry picked from commit 5a0a0a2)

@kkrushnyakov kkrushnyakov deleted the kkrushnyakov:user_agent_http_header_patch branch Aug 13, 2015

chrisholmes added a commit to chrisholmes/dropwizard that referenced this pull request Aug 14, 2015

Merge pull request dropwizard#1198 from kkrushnyakov/user_agent_http_…
…header_patch

Fixed user modifications of 'User-Agent' http header on requests

Closes dropwizard#1157
(cherry picked from commit 5a0a0a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment