New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require username in the data source configuration #1260

Merged
merged 1 commit into from Sep 24, 2015

Conversation

Projects
None yet
2 participants
@arteam
Member

arteam commented Sep 24, 2015

Some platforms provide credentials to connect to a database inlined in the connection URL. Examples:

  • postgres://postgres:SOME_PASSWORD@172.17.0.1:5432/lolipop
  • jdbc:h2:file:~/sample;USER=sa;PASSWORD=123
  • jdbc:postgresql://localhost/test?user=fred&password=secret

JDBC drivers support such a type of configuration. We should respect it and provide users ability to use it.

It means we should not require the username field to be set in the data source configuration.

Fixes #1259

Don't require username in the data source configuration
Some platforms provide credentials to connect to a database
inlined in the connection URL. Examples:

* `postgres://postgres:SOME_PASSWORD@172.17.0.1:5432/lolipop`
* ` jdbc:h2:file:~/sample;USER=sa;PASSWORD=123`
* `jdbc:postgresql://localhost/test?user=fred&password=secret`

JDBC drivers support such a type of configuration. We should
respect it and provide users ability to use it.

It means we should not require the username field to be set in the
data source configuration.

Fixes #1259
@jplock

This comment has been minimized.

Show comment
Hide comment
@jplock

jplock Sep 24, 2015

Member

LGTM!

Member

jplock commented Sep 24, 2015

LGTM!

jplock added a commit that referenced this pull request Sep 24, 2015

Merge pull request #1260 from arteam/db-factory-inline-credentials
Don't require username in the data source configuration

@jplock jplock merged commit 2518a73 into dropwizard:master Sep 24, 2015

@jplock jplock added this to the 0.9.0 milestone Sep 24, 2015

@arteam arteam deleted the arteam:db-factory-inline-credentials branch Jan 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment