New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPI for RequestLogFactory #1290

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@mwhipple
Contributor

mwhipple commented Oct 20, 2015

Allows for overriding of RequestLog implementation such as to allow use of logback-access

@arteam arteam closed this in 05d3fcd Nov 21, 2015

@arteam

This comment has been minimized.

Member

arteam commented Nov 21, 2015

Thanks! Applied to master in 05d3fcd with some enhancements.

@joschi joschi added this to the 1.0.0 milestone Nov 21, 2015

ghenkes added a commit to ghenkes/dropwizard that referenced this pull request Jan 12, 2016

Make RequestLogFactory a SPI
Move the SLF4J implentation to a separate class.

Closes dropwizard#1290
@mattnelson

This comment has been minimized.

Contributor

mattnelson commented Jan 12, 2016

@mwhipple Do you have an implementation using these changes for logback-access? I am also looking for this feature and would like to avoid reimplementing.

@mwhipple

This comment has been minimized.

Contributor

mwhipple commented Jan 13, 2016

@mattnelson I should be able to get something together that I can post for you in some form if not as a directly usable artifact tomorrow. The working implementation with logback-access that I have doesn't use this change and instead extends the top level configuration object (the ugliness of which inspired the PR)

@mwhipple

This comment has been minimized.

Contributor

mwhipple commented Jan 14, 2016

I'd left out extending Discoverable so the logback access module won't be as convenient to use pending #1412, but it should be able to be handled with an explicit registration of a Jackson module in the consuming service. I extracted most of the implementation and I'll publish the present state in the morning (should work but could stand cleanup) and work on info about the Jackson module when time allows.

@mwhipple

This comment has been minimized.

Contributor

mwhipple commented Jan 14, 2016

@mattnelson https://github.com/mwhipple/dropwizard-logback-access - still awaiting enough time to be in a presentable state and published but at least enough to start with.

ghenkes added a commit to ghenkes/dropwizard that referenced this pull request Jan 14, 2016

Make RequestLogFactory a SPI
Move the SLF4J implentation to a separate class.

Closes dropwizard#1290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment