New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnwrapValidatedValue annotation to `BaseReporterFactory.frequency` #1309

Merged
merged 1 commit into from Oct 28, 2015

Conversation

Projects
None yet
5 participants
@evnm
Member

evnm commented Oct 28, 2015

Proposed fix for #1308. I'm not familiar with how validations are tested in the Dropwizard codebase, so please advise on how I can write a test for this change.

@arteam

This comment has been minimized.

Member

arteam commented Oct 28, 2015

Looks like this is a similar issue to #1292. Hibernate Validator 5.2 now requries UnwrapValidatedValue on containers. For some reason, we missed that during release candidates...

@nickbabcock nickbabcock added the bug label Oct 28, 2015

nickbabcock added a commit that referenced this pull request Oct 28, 2015

Merge pull request #1309 from evnm/dropwizard-metrics/unwrap-validate…
…d-frequency

Add UnwrapValidatedValue annotation to `BaseReporterFactory.frequency`

@nickbabcock nickbabcock merged commit cae8572 into dropwizard:master Oct 28, 2015

@jplock

This comment has been minimized.

Member

jplock commented Oct 28, 2015

We should get this into release/0.9.x as well for a 0.9.1 release I think.

@jplock jplock added this to the 0.9.1 milestone Oct 28, 2015

nickbabcock added a commit that referenced this pull request Oct 28, 2015

Merge pull request #1309 from evnm/dropwizard-metrics/unwrap-validate…
…d-frequency

Add UnwrapValidatedValue annotation to `BaseReporterFactory.frequency`
(cherry picked from commit cae8572)
@joschi

This comment has been minimized.

Member

joschi commented Oct 29, 2015

@jplock Agreed, see 15b6533.

@evnm evnm deleted the evnm:dropwizard-metrics/unwrap-validated-frequency branch Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment