New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting default headers in Apache HTTP client #1354

Merged
merged 1 commit into from Nov 25, 2015

Conversation

Projects
None yet
2 participants
@arteam
Member

arteam commented Nov 25, 2015

Add the ability to set predefined HTTP headers for each HTTP request of an HTTP client.

Apache HttpClientBuilder already supports such functionality and we should just delegate building from Dropwizard HttpClientBuilder.

In the result users can provide own headers without subclassing Dropwizard HttpClientBuilder.

Resolves #1353

Add support for setting default headers in Apache HTTP client
Add the ability to set predefined HTTP headers for each HTTP
request of an HTTP client.

Apache `HttpClientBuilder` already supports such functionality
and we should just delegate building from Dropwizard
`HttpClientBuilder`.

In the result users can provide own headers without subclassing
Dropwizard `HttpClientBuilder`.

Resolves #1353
@jplock

This comment has been minimized.

Show comment
Hide comment
@jplock

jplock Nov 25, 2015

Member

LGTM! Thanks!

Member

jplock commented Nov 25, 2015

LGTM! Thanks!

jplock added a commit that referenced this pull request Nov 25, 2015

Merge pull request #1354 from arteam/http_client_default_headers
Add support for setting default headers in Apache HTTP client

@jplock jplock merged commit e2ff80b into dropwizard:master Nov 25, 2015

@jplock jplock added the improvement label Nov 25, 2015

@jplock jplock added this to the 1.0.0 milestone Nov 25, 2015

@arteam arteam deleted the arteam:http_client_default_headers branch Jan 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment