New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DropwizardAppRule start and stop app only once, even when called recursively #1411

Merged
merged 2 commits into from Jan 14, 2016

Conversation

Projects
None yet
2 participants
@qualidafial

qualidafial commented Jan 13, 2016

We've found on our projects that builds go significantly faster if we use DropwizardAppRule at the suite level.

This however makes it difficult to run individual tests in isolation.

This pull request makes DropwizardAppRule usable in a recursive way, but only starts and stops the application once for the outer call. With this change we are able to run the entire test suite, or a single test in a single class, and the application will be started/stopped once and only once.

There are usage examples in the javadoc changes.

Matthew Hall
Make DropwizardAppRule start and stop the application only once, even…
… when used recursively (i.e. by sharing the same rule instance at the suite- and class-level).

arteam added a commit that referenced this pull request Jan 14, 2016

Merge pull request #1411 from zanebenefits/recursive-app-rule
Make DropwizardAppRule start and stop app only once, even when called recursively

@arteam arteam merged commit 140e492 into dropwizard:master Jan 14, 2016

@qualidafial qualidafial deleted the zanebenefits:recursive-app-rule branch Jan 14, 2016

@arteam

This comment has been minimized.

Show comment
Hide comment
@arteam

arteam Jan 14, 2016

Member

Thanks for contributing to Dropwizard!

Member

arteam commented Jan 14, 2016

Thanks for contributing to Dropwizard!

@arteam arteam added the improvement label Jan 14, 2016

@arteam arteam added this to the 1.0.0 milestone Jan 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment