New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OptionalValidatedValueUnwrapper #1583

Merged
merged 1 commit into from Jul 27, 2016

Conversation

Projects
None yet
4 participants
@nickbabcock
Contributor

nickbabcock commented Jun 3, 2016

As now that Hibernate validator implements it internally, ours is no
longer needed (or even used, as Hibernate prefers its own).

I'm marking this as for the 1.1, let me know if anyone disagrees (ie. don't merge this until at least 1.0 is out (or create 1.1 branch?))

Remove OptionalValidatedValueUnwrapper
As now that Hibernate validator implements it internally, ours is no
longer needed (or even used, as Hibernate prefers its own).

@nickbabcock nickbabcock added this to the 1.1.0 milestone Jun 3, 2016

@joschi

This comment has been minimized.

Member

joschi commented Jun 3, 2016

Good idea, thanks! 👍

@coveralls

This comment has been minimized.

coveralls commented Jun 3, 2016

Coverage Status

Coverage increased (+0.03%) to 81.284% when pulling a2310ec on nickbabcock:remove-optional into 8ba1842 on dropwizard:master.

@jplock jplock added the improvement label Jul 27, 2016

@jplock jplock merged commit f9e5e44 into dropwizard:master Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment