New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Dropwizard constraints to be applied to type #1586

Merged
merged 2 commits into from Jul 27, 2016

Conversation

Projects
None yet
3 participants
@nickbabcock
Contributor

nickbabcock commented Jun 3, 2016

Java 8 allows the following code to be valid:

@Valid
List<@OneOf({"one", "two", "three"}) String> bar;

But as the annotations are defined know, they will fail to compile. The
fix is simple, add TYPE_USE to the constraint annotation.

Allow Dropwizard constraints to be applied to type
Java 8 allows the following code to be valid:

```java
@Valid
List<@OneOf({"one", "two", "three"}) String> bar;
```

But as the annotations are defined know, they will fail to compile. The
fix is simple, add `TYPE_USE` to the constraint annotation.

@nickbabcock nickbabcock added this to the 1.1.0 milestone Jun 3, 2016

@coveralls

This comment has been minimized.

coveralls commented Jun 3, 2016

Coverage Status

Coverage remained the same at 81.256% when pulling 0206fb8 on nickbabcock:type-valid-annotation into 8ba1842 on dropwizard:master.

@jplock jplock added the improvement label Jun 9, 2016

@jplock jplock merged commit 3f1987d into dropwizard:master Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment