New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GZipHandler sync-flush configurable #1673 #1685

Merged
merged 1 commit into from Aug 12, 2016

Conversation

Projects
None yet
5 participants
@LeDominik
Contributor

LeDominik commented Aug 12, 2016

This would resolve #1673 by making sync-flush behaviour of GZipHandler configurable

@coveralls

This comment has been minimized.

coveralls commented Aug 12, 2016

Coverage Status

Changes Unknown when pulling 88b8091 on LeDominik:master into * on dropwizard:master*.

@evnm

This comment has been minimized.

Member

evnm commented Aug 12, 2016

Change looks great. Thanks for the contribution!

I guess we can punt on adding similar configurability for path/MIME-type inclusion/exclusion as a separate change, if there's still any interest in doing so.

@evnm evnm merged commit 293cfed into dropwizard:master Aug 12, 2016

@evnm evnm added the improvement label Aug 12, 2016

@evnm evnm added this to the 1.1.0 milestone Aug 12, 2016

@LeDominik

This comment has been minimized.

Contributor

LeDominik commented Aug 12, 2016

I think this solution is great, it's about streaming and not about MIME types so for this purpose the change just feels right 👍

@victornoel

This comment has been minimized.

Contributor

victornoel commented Mar 6, 2017

@evnm is this present in 1.1.x only?

@arteam

This comment has been minimized.

Member

arteam commented Mar 6, 2017

Yes, but we can backport it to 1.0.* if it's needed.

@victornoel

This comment has been minimized.

Contributor

victornoel commented Mar 6, 2017

@arteam for now I enable it by myself with this workaround:

        environment.lifecycle().addServerLifecycleListener(server -> {
            Handler handler = server.getHandler();
            while (handler instanceof HandlerWrapper) {
                handler = ((HandlerWrapper) handler).getHandler();
                if (handler instanceof BiDiGzipHandler) {
                    LOG.info("Setting sync flush on gzip compression handler");
                    ((BiDiGzipHandler) handler).setSyncFlush(true);
                }
            }
        });

So don't bother with it except if it's very easy and you plan to release many 1.0.x before 1.1.x is released :)
Thanks!

@victornoel

This comment has been minimized.

Contributor

victornoel commented Mar 22, 2017

@arteam by the way, I think you forgot to add it to the changelog of the released 1.1.0 :)

arteam added a commit that referenced this pull request Mar 22, 2017

arteam added a commit that referenced this pull request Mar 22, 2017

@arteam

This comment has been minimized.

Member

arteam commented Mar 22, 2017

The improvement has been added to the changelog. Thanks for letting us know!

arteam added a commit that referenced this pull request Mar 22, 2017

aaanders added a commit to aaanders/dropwizard that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment