New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Jetty initialized SSLContext not the Default #1698

Merged
merged 1 commit into from Aug 19, 2016

Conversation

Projects
None yet
3 participants
@nickbabcock
Contributor

nickbabcock commented Aug 18, 2016

Instead of listing supported cipher suites, protocols, etc of the default
SSLContext algorithm, log what Jetty's will actually use, which as of this
commit is a "TLS" SSLContext. This will also future proof the logging if
this property ever becomes configurable in Dropwizard.

Log Jetty initialized SSLContext not the Default
Instead of listing supported cipher suites, protocols, etc of the default
SSLContext algorithm, log what Jetty's will actually use, which as of this
commit is a "TLS" SSLContext. This will also future proof the logging if
this property ever becomes configurable in Dropwizard.

@nickbabcock nickbabcock force-pushed the nickbabcock:log-jetty-ssl-context branch from 3d4b783 to 45687ed Aug 18, 2016

@coveralls

This comment has been minimized.

coveralls commented Aug 18, 2016

Coverage Status

Coverage decreased (-0.2%) to 82.22% when pulling 45687ed on nickbabcock:log-jetty-ssl-context into ab74bbf on dropwizard:master.

@evnm

This comment has been minimized.

Member

evnm commented Aug 18, 2016

LGTM

@evnm evnm merged commit 8d5756c into dropwizard:master Aug 19, 2016

@evnm evnm added this to the 1.0.1 milestone Aug 19, 2016

@evnm evnm added the improvement label Aug 19, 2016

arteam added a commit that referenced this pull request Sep 21, 2016

Log Jetty initialized SSLContext not the Default (#1698)
Instead of listing supported cipher suites, protocols, etc of the default
SSLContext algorithm, log what Jetty's will actually use, which as of this
commit is a "TLS" SSLContext. This will also future proof the logging if
this property ever becomes configurable in Dropwizard.

(cherry picked from commit 8d5756c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment