New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SizeParam as a request parameter #1751

Merged
merged 1 commit into from Sep 29, 2016

Conversation

Projects
None yet
4 participants
@nickbabcock
Contributor

nickbabcock commented Sep 29, 2016

Duration param was created in #1734, so it's brother (Size) should have a param class too

@nickbabcock nickbabcock force-pushed the nickbabcock:size-param branch from 3c97dfb to 5f02c59 Sep 29, 2016

@coveralls

This comment has been minimized.

coveralls commented Sep 29, 2016

Coverage Status

Coverage increased (+0.09%) to 82.103% when pulling 5f02c59 on nickbabcock:size-param into b1c563e on dropwizard:master.

@Override
protected String errorMessage(Exception e) {
return "%s is not a valid duration.";

This comment has been minimized.

@evnm

evnm Sep 29, 2016

Member

s/duration/size/

final Response response = ((WebApplicationException) exn).getResponse();
assertThat(response.getStatus()).isEqualTo(400);
assertThat((ErrorMessage) response.getEntity())
.isEqualTo(new ErrorMessage(400, "degrees is not a valid duration."));

This comment has been minimized.

@evnm

evnm Sep 29, 2016

Member

s/duration/size/

@nickbabcock nickbabcock force-pushed the nickbabcock:size-param branch from 5f02c59 to 8a4e4ef Sep 29, 2016

@nickbabcock

This comment has been minimized.

Contributor

nickbabcock commented Sep 29, 2016

Kids, the danger of copying + pasting 😊

Good catch!

@jplock jplock added the feature label Sep 29, 2016

@jplock jplock added this to the 1.1.0 milestone Sep 29, 2016

@coveralls

This comment has been minimized.

coveralls commented Sep 29, 2016

Coverage Status

Coverage increased (+0.09%) to 82.103% when pulling 8a4e4ef on nickbabcock:size-param into b1c563e on dropwizard:master.

@jplock

This comment has been minimized.

Member

jplock commented Sep 29, 2016

LGTM

@jplock jplock merged commit dff1f58 into dropwizard:master Sep 29, 2016

@nickbabcock

This comment has been minimized.

Contributor

nickbabcock commented Sep 29, 2016

Updated release notes in 6963cb9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment