New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer use of assertj's java8 exception assertions #1753

Merged
merged 1 commit into from Sep 30, 2016

Conversation

Projects
None yet
3 participants
@nickbabcock
Contributor

nickbabcock commented Sep 30, 2016

The current usage of fail() in tests can't beat the messages produced by assertj's built in exception assertions. It also can't beat the conciseness 馃槃

The next step may be to examine if we want to replace failBecauseExceptionWasNotThrown with exception assertions

@evnm evnm added the improvement label Sep 30, 2016

@evnm evnm added this to the 1.0.3 milestone Sep 30, 2016

@coveralls

This comment has been minimized.

coveralls commented Sep 30, 2016

Coverage Status

Coverage remained the same at 82.103% when pulling 467c227 on nickbabcock:update-throw-tests into 6963cb9 on dropwizard:master.

@evnm evnm merged commit 980ef7c into dropwizard:master Sep 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment