New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web test container agnostic client target #1778

Merged
merged 1 commit into from Oct 20, 2016

Conversation

Projects
None yet
3 participants
@nickbabcock
Contributor

nickbabcock commented Oct 20, 2016

Depending on the web test container passed to
ResourceTestRule#setTestContainerFactory, one would either invoke
client() or getJerseyTest(), which is inconvenient. The fix is to
standardize on a new method that can be used regardless of web test
container that also doesn't infringe on the law of Demeter (as the other
solution would be to rewrite all usage as using getJerseyTest())

@jplock jplock added the improvement label Oct 20, 2016

@jplock jplock added this to the 1.1.0 milestone Oct 20, 2016

Add web test container agnostic client target
Depending on the web test container passed to
`ResourceTestRule#setTestContainerFactory`, one would either invoke
`client()` or `getJerseyTest()`, which is inconvenient. The fix is to
standardize on a new method that can be used regardless of web test
container that also doesn't infringe on the law of Demeter.

@nickbabcock nickbabcock force-pushed the nickbabcock:webtest-client-conform branch from f27acb2 to 0141b20 Oct 20, 2016

@coveralls

This comment has been minimized.

coveralls commented Oct 20, 2016

Coverage Status

Coverage increased (+0.02%) to 82.296% when pulling 0141b20 on nickbabcock:webtest-client-conform into 029ef03 on dropwizard:master.

@jplock jplock merged commit 426c375 into dropwizard:master Oct 20, 2016

@nickbabcock

This comment has been minimized.

Contributor

nickbabcock commented Oct 21, 2016

Updated release notes in 9a41974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment