New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added httpCompliance to the HttpConnectorFactory #1825

Merged
merged 3 commits into from Nov 16, 2016

Conversation

Projects
None yet
4 participants
@dren-dk
Contributor

dren-dk commented Nov 16, 2016

Here's my shot at implementing the change discussed in issue 1824:
#1824

@coveralls

This comment has been minimized.

coveralls commented Nov 16, 2016

Coverage Status

Coverage decreased (-0.03%) to 81.876% when pulling 4eb5c2f on dren-dk:master into 867a101 on dropwizard:master.

@arteam

This comment has been minimized.

Member

arteam commented Nov 16, 2016

Looks good. A couple of requests:

  • Could you please update HttpConnectorFactoryTest? We have 3 relevant tests for it (default configuration, full configuration, and a test for building a connector).
  • Could please add this parameters to HttpConnectorFactory's javadoc and the configuration reference? This should allow other users to know how to set the parameter and its purpose.
@dren-dk

This comment has been minimized.

Contributor

dren-dk commented Nov 16, 2016

On it.

@dren-dk

This comment has been minimized.

Contributor

dren-dk commented Nov 16, 2016

Ok, I have added test code and javadoc.

@coveralls

This comment has been minimized.

coveralls commented Nov 16, 2016

Coverage Status

Coverage increased (+0.01%) to 81.918% when pulling 12329c9 on dren-dk:master into 867a101 on dropwizard:master.

@jplock jplock added the improvement label Nov 16, 2016

@jplock jplock added this to the 1.1.0 milestone Nov 16, 2016

@arteam arteam merged commit f9470d7 into dropwizard:master Nov 16, 2016

@arteam

This comment has been minimized.

Member

arteam commented Nov 16, 2016

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment