Switch cert and peer validation to false by default #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any either of these two options are enabled, a HTTPs enabled Dropwizard app will most likely fail to start with cryptic error messages. Since Jetty has these options disabled by default, we should follow their lead and disable these options as well. Future work includes adding in additional certificate features as Certificate Revocation List (CRL), CRL Distribution Points Protocol (CRLDP), On-Line Certificate Status Protocol (OCSP)
|
Makes sense to me. We should be noisy when releasing this in the next stable versions, given the possibility that it changes behavior out from under folks. |
|
Makes sense to me as well. Merged to upstream and applied to the 1.0.x branch as 7be0112. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any either of these two options are enabled, a HTTPs enabled Dropwizard
app will most likely fail to start with cryptic error messages. Since
Jetty has these options disabled by default, we should follow their lead
and disable these options as well.
Future work includes adding in additional certificate features as
Certificate Revocation List (CRL), CRL Distribution Points Protocol
(CRLDP), On-Line Certificate Status Protocol (OCSP)
This may be considered a bugfix and is a candidate for either 1.0.x or 1.1