New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default WebExceptionMapper preserves exception HTTP headers #1912

Merged
merged 2 commits into from Feb 2, 2017

Conversation

Projects
None yet
3 participants
@nickbabcock
Contributor

nickbabcock commented Feb 2, 2017

Closes #1866

Technically, the code doesn't need to try and detect for redirection (introduced in #1452) as the Location header gets through now (and all tests would pass), but I didn't remove it because redirect responses would contain a JSON payload, which some people may or may not like.

@coveralls

This comment has been minimized.

coveralls commented Feb 2, 2017

Coverage Status

Coverage decreased (-0.003%) to 81.843% when pulling b033549 on nickbabcock:webexceptionHeaders into 045976c on dropwizard:master.

@nickbabcock nickbabcock force-pushed the nickbabcock:webexceptionHeaders branch from b033549 to b431534 Feb 2, 2017

@jplock jplock added the bug label Feb 2, 2017

@jplock jplock added this to the 1.1.0 milestone Feb 2, 2017

@coveralls

This comment has been minimized.

coveralls commented Feb 2, 2017

Coverage Status

Coverage decreased (-0.003%) to 81.843% when pulling b431534 on nickbabcock:webexceptionHeaders into 045976c on dropwizard:master.

@nickbabcock nickbabcock force-pushed the nickbabcock:webexceptionHeaders branch from b431534 to 79406f5 Feb 2, 2017

nickbabcock added some commits Feb 2, 2017

Preserves headers from exception in response
Use case: enables NotAllowedException to communicate the valid allowed
methods on the given endpoint via the "Allow" HTTP header.

@nickbabcock nickbabcock force-pushed the nickbabcock:webexceptionHeaders branch from 79406f5 to a6acf73 Feb 2, 2017

@jplock jplock merged commit 0e34c66 into dropwizard:master Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment