Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
dropwizard-auth: Add support for optional resource protection #1931
The current support for optionally-protected resources isn't great. We require users to implement a custom auth filter to inject a dummy
I had occasion to write such an endpoint at work and decided to take a stab at supporting
This change breaks down into two steps:
These two new classes are wired into
@evnm Is there any chance that this feature could make it into an earlier milestone, perhaps the 1.1.x release?
I really need optional resource protection for something I'm working on now, and was actually about to go and write a PR for the exact same approach myself, so I was really delighted to see this written and merged. I was slightly less delighted to see it's two whole minor versions away.
I can rely on 1.2.0-SNAPSHOT for a bit while developing, but I don't want to roll something into prod with a snapshot dependency.
Since Dropwizard made a breaking change to remove the optional flag from
@ibwhite I also would like to be able to make use of this change in production, so I share your sense of haste.
I'm going to defer to other committers, though. It seems to me that it's somewhat debatable whether this change represents an introduction of new functionality or, as you say, a bugfix-esque improvement. @jplock, @arteam, what do you guys think?