Implement TaskServlet::doGet to list tasks lexically. #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement doGet in TaskServlet in order to be able to query registered tasks. Returns the registered tasks ordered lexically by Task::getName. Since TaskServlet matches "/tasks/*" any GET request not matching root will yield 404 or 405. 404: Task name is unknown. 405: Task name is registered but must be invoked with POST.
Closed
joschi
requested changes
Feb 27, 2017
| if (Strings.isNullOrEmpty(req.getPathInfo())) { | ||
| try (final PrintWriter output = resp.getWriter()) { | ||
| resp.setContentType(MediaType.PLAIN_TEXT_UTF_8.toString()); | ||
| final ArrayList<Task> tasks = new ArrayList<>(getTasks()); |
There was a problem hiding this comment.
This (and the following lines) could be replaced by:
getTasks().stream()
.map(Task::getName)
.sorted()
.forEach(output::println);There was a problem hiding this comment.
Nice, thanks @joschi, nice and clean. (Grepping for stream() made me think it was a bad idea to use it :D )
joschi
requested changes
Feb 27, 2017
| import com.google.common.collect.ImmutableMultimap; | ||
| import com.google.common.io.CharStreams; | ||
| import com.google.common.net.MediaType; | ||
| import java.util.ArrayList; |
There was a problem hiding this comment.
Please remove the unused imports. Then we're good to go.
* Use stream() when looping, sorting and printing task names.
joschi
approved these changes
Feb 27, 2017
joschi
pushed a commit
that referenced
this pull request
Feb 27, 2017
Implement doGet in TaskServlet in order to be able to query registered tasks. Returns the registered tasks ordered lexically by Task::getName. Since TaskServlet matches "/tasks/*" any GET request not matching root will yield 404 or 405. 404: Task name is unknown. 405: Task name is registered but must be invoked with POST. Closes #1940 (cherry picked from commit e94deb2)
|
Thanks for reviewing @joschi |
nickbabcock
added a commit
that referenced
this pull request
Mar 8, 2017
nickbabcock
added a commit
that referenced
this pull request
Mar 8, 2017
aaanders
pushed a commit
to aaanders/dropwizard
that referenced
this pull request
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks are logged on startup but aren't easily accessible otherwise. Implement
TaskServlet::doGetto print tasks lexically by name.Example:
TaskServlet is mapped on "/tasks/*" and any GET request not matching root
will yield 404 or 405.
404: Task name is unknown.
405: Task name is registered but must be invoked with POST.