New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the console logging context after a reset #1973

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
4 participants
@arteam
Member

arteam commented Mar 23, 2017

When resetting logging, we should set a context for the console appender. Otherwise, we get an annoying message: LOGBACK: No context given for ch.qos.logback.core.ConsoleAppender[null] in the tests which use DropwizardAppRule.

This is related to #1947.

Set the console logging context after a reset
When resetting logging, we should set a context for the console appender.
Otherwise, we get an annoying message:
`LOGBACK: No context given for ch.qos.logback.core.ConsoleAppender[null]`
in the tests which use `DropwizardAppRule`.
@coveralls

This comment has been minimized.

coveralls commented Mar 23, 2017

Coverage Status

Coverage decreased (-0.02%) to 84.745% when pulling f2f1d20 on set_console_context_on_reset into b9fad10 on release/1.1.x.

@arteam arteam added this to the 1.1.0 milestone Mar 23, 2017

@arteam arteam added the improvement label Mar 23, 2017

@jplock jplock modified the milestones: 1.1.0, 1.1.1 Mar 23, 2017

@jplock jplock merged commit 8cd35e4 into release/1.1.x Mar 23, 2017

@jplock jplock deleted the set_console_context_on_reset branch Mar 23, 2017

@shawnsmith

This comment has been minimized.

Contributor

shawnsmith commented Jul 26, 2017

FYI: I'm getting a new Logback status warning from any attempt to use this ConsoleAppender because its start() method is never called. Hooking up the context allows the context to capture the following warning:

WARN in ch.qos.logback.core.ConsoleAppender[null] - Attempted to append to non started appender [null].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment