New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set logging context for file appenders before setting the buffer size #1975

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@arteam
Member

arteam commented Mar 23, 2017

Setting buffer size results in writing an internal log message: Setting bufferSize to ....
If the context is not set, then Logback writes a log message: LOGBACK: No context given for ch.qos.logback.core.FileAppender[null] to the console log. It's a little bit annoying and we can avoid by setting the context right after instantiating the appenders.

This is related to #1951.

Set the logging context for file appenders before setting the buffer …
…size

Setting buffer size results in writing an internal log message:
 `Setting bufferSize to ...`.
If the context is not set, then Logback writes a log message:
`LOGBACK: No context given for ch.qos.logback.core.FileAppender[null]`
to the console log. It's a little bit annoying and we can avoid by setting
the context right after instantiating the appenders.

@arteam arteam added this to the 1.1.0 milestone Mar 23, 2017

@coveralls

This comment has been minimized.

coveralls commented Mar 23, 2017

Coverage Status

Coverage increased (+0.004%) to 84.773% when pulling fc4fde0 on set_context_for_file_logger into b9fad10 on release/1.1.x.

@arteam arteam added the improvement label Mar 23, 2017

@jplock jplock modified the milestones: 1.1.0, 1.1.1 Mar 23, 2017

@jplock jplock merged commit 442b44f into release/1.1.x Mar 23, 2017

@jplock jplock deleted the set_context_for_file_logger branch Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment