New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @UnwrapValidatedValue annotations #1993

Merged
merged 1 commit into from Apr 2, 2017

Conversation

Projects
None yet
5 participants
@joschi
Member

joschi commented Mar 31, 2017

Some classes/fields were missing the @UnwrapValidatedValue annotations in combination with javax.validation annotations.

@joschi joschi added this to the 1.1.1 milestone Mar 31, 2017

@arteam

This comment has been minimized.

Member

arteam commented Mar 31, 2017

Does this this bug cause #1990?

@coveralls

This comment has been minimized.

coveralls commented Mar 31, 2017

Coverage Status

Coverage remained the same at 84.749% when pulling 71e1c80 on missing-unwrapvalidatedvalue into 442b44f on release/1.1.x.

@jplock jplock added the bug label Mar 31, 2017

@evnm

This comment has been minimized.

Member

evnm commented Apr 1, 2017

Change LGTM.

@arteam I wouldn't think so. The fields claimed to trigger the issue in #1990 aren't optional, so the @UnwrapValidatedValue shouldn't be relevant to them.

@joschi

This comment has been minimized.

Member

joschi commented Apr 2, 2017

Does this this bug cause #1990?

No, but I discovered the missing annotations while looking into that issue.

@evnm evnm merged commit 68ca5fb into release/1.1.x Apr 2, 2017

@joschi joschi deleted the missing-unwrapvalidatedvalue branch Apr 3, 2017

joschi added a commit that referenced this pull request Apr 3, 2017

Add missing `@UnwrapValidatedValue` annotations
Refs #1993
(cherry picked from commit 68ca5fb)

aaanders added a commit to aaanders/dropwizard that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment