Add new criteriaQuery method to avoid hibernate criteria deprecations. #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightswitch05
force-pushed
the
feature/criteria-query
branch
from
2fb3a5c
to
1f87c2c
Compare
arteam
approved these changes
Apr 26, 2017
Looks good to me!
I don't have anything against createCriteriaUpdate and createCriteriaDelete. I think you can create a pull request and we will consider to include it.
| * @return a new {@link CriteriaQuery} query | ||
| */ | ||
| protected CriteriaQuery<E> criteriaQuery() { | ||
| CriteriaBuilder builder = this.currentSession().getCriteriaBuilder(); |
There was a problem hiding this comment.
I think the builder variable could be omitted because it's used only once.
lightswitch05
force-pushed
the
feature/criteria-query
branch
from
184b75f
to
4b31edf
Compare
|
Thanks for the contribution! |
aaanders
pushed a commit
to aaanders/dropwizard
that referenced
this issue
Sep 20, 2018
dropwizard#2028) * Add new criteriaQuery method to avoid hibernate criteria deprecations. * Remove builder variable per code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hibernate deprecated
session.createCriteria(<E>).I added a
criteriaQuery()method as a migration path away fromcriteria(). I consideredcreateCriteriaUpdateandcreateCriteriaDeletemethods as well, but wasn't sure if they would be wanted. Please let me know your thoughts.