Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd new criteriaQuery method to avoid hibernate criteria deprecations. #2028
Conversation
lightswitch05
force-pushed the
lightswitch05:feature/criteria-query
branch
from
2fb3a5c
to
1f87c2c
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Apr 26, 2017
|
Looks good to me! I don't have anything against |
| * @return a new {@link CriteriaQuery} query | ||
| */ | ||
| protected CriteriaQuery<E> criteriaQuery() { | ||
| CriteriaBuilder builder = this.currentSession().getCriteriaBuilder(); |
This comment has been minimized.
This comment has been minimized.
arteam
Apr 26, 2017
Member
I think the builder variable could be omitted because it's used only once.
lightswitch05
force-pushed the
lightswitch05:feature/criteria-query
branch
from
184b75f
to
4b31edf
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Apr 26, 2017
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Apr 26, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the contribution! |
aaanders
added a commit
to aaanders/dropwizard
that referenced
this pull request
Sep 20, 2018
dropwizard#2028) * Add new criteriaQuery method to avoid hibernate criteria deprecations. * Remove builder variable per code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lightswitch05 commentedApr 26, 2017
Hibernate deprecated
session.createCriteria(<E>).I added a
criteriaQuery()method as a migration path away fromcriteria(). I consideredcreateCriteriaUpdateandcreateCriteriaDeletemethods as well, but wasn't sure if they would be wanted. Please let me know your thoughts.