New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDBC interceptor configuration #2030

Merged
merged 1 commit into from Apr 26, 2017

Conversation

Projects
None yet
3 participants
@nickbabcock
Contributor

nickbabcock commented Apr 26, 2017

Had a conversation with the author or hikaricp where tomcat jdbc should have various interceptors on by default like ConnectionState, and I realized that one can't specify interceptors through the db yaml. This is a good first step.

Closes #1960

CC @ololoken of #1960

@nickbabcock nickbabcock added this to the 1.2.0 milestone Apr 26, 2017

@nickbabcock nickbabcock force-pushed the nickbabcock:add-interceptors branch from 9e8cd79 to 2be7116 Apr 26, 2017

@coveralls

This comment has been minimized.

coveralls commented Apr 26, 2017

Coverage Status

Coverage increased (+0.01%) to 84.498% when pulling 2be7116 on nickbabcock:add-interceptors into ecf06ce on dropwizard:master.

@coveralls

This comment has been minimized.

coveralls commented Apr 26, 2017

Coverage Status

Coverage increased (+0.01%) to 84.498% when pulling 2be7116 on nickbabcock:add-interceptors into ecf06ce on dropwizard:master.

@jplock

jplock approved these changes Apr 26, 2017

Looks good to me

@jplock jplock merged commit bb0e6fe into dropwizard:master Apr 26, 2017

4 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 84.498%
Details

nickbabcock added a commit that referenced this pull request Apr 27, 2017

aaanders added a commit to aaanders/dropwizard that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment