New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HttpSessionListener.sessionDestroyed is not being called #2031 #2032

Merged
merged 2 commits into from Apr 28, 2017

Conversation

Projects
None yet
6 participants
@t-tsutsumi
Contributor

t-tsutsumi commented Apr 27, 2017

Solves: #2031

Also, in order to make it possible to detect degradation caused by Jetty's version upgrade, I added several tests.

@coveralls

This comment has been minimized.

coveralls commented Apr 27, 2017

Coverage Status

Coverage increased (+0.002%) to 84.502% when pulling d8a198f on t-tsutsumi:pr/implement-HandlerContainer into 10dad0f on dropwizard:master.

@coveralls

This comment has been minimized.

coveralls commented Apr 27, 2017

Coverage Status

Coverage increased (+0.002%) to 84.502% when pulling d8a198f on t-tsutsumi:pr/implement-HandlerContainer into 10dad0f on dropwizard:master.

@arteam

arteam approved these changes Apr 27, 2017

@jplock jplock added this to the 1.2.0 milestone Apr 27, 2017

@jplock jplock added the bug label Apr 27, 2017

@nickbabcock nickbabcock merged commit 223f9c1 into dropwizard:master Apr 28, 2017

4 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 84.502%
Details

@t-tsutsumi t-tsutsumi deleted the t-tsutsumi:pr/implement-HandlerContainer branch Apr 28, 2017

@CodingFabian

This comment has been minimized.

CodingFabian commented Apr 30, 2017

is it possible to merge this to 1.1.x? as its actually a 1.1.x regression due to jetty upgrade.

We would like to be able to use this feature again without the need to wait for 1.2

@jplock

This comment has been minimized.

Member

jplock commented May 1, 2017

I cherry-picked these commits in bfc370b and 5f85ffa into the release/1.1.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment