Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Java 8 InstantParam with test. #2048

Merged
merged 1 commit into from May 9, 2017

Conversation

lightswitch05
Copy link
Contributor

@lightswitch05 lightswitch05 commented May 8, 2017

Some java 8 users might want to avoid Joda-Time in favor of Instant

@coveralls
Copy link

@coveralls coveralls commented May 8, 2017

Coverage Status

Coverage increased (+0.01%) to 84.535% when pulling 53d78e5 on lightswitch05:feature/instant-param into cebf1d6 on dropwizard:master.

@joschi joschi self-assigned this May 8, 2017
@joschi joschi self-requested a review May 8, 2017
@jplock jplock added this to the 1.2.0 milestone May 8, 2017
import java.time.ZoneOffset;
import java.time.LocalDateTime;

/**
Copy link
Member

@joschi joschi May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the @author tag (or rather the complete Javadoc comment).

Copy link
Contributor Author

@lightswitch05 lightswitch05 May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that one, editor added it automatically.

/**
* @author Daniel White
*/
public class InstantParamTest {
Copy link
Member

@joschi joschi May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case for bad input.

@coveralls
Copy link

@coveralls coveralls commented May 8, 2017

Coverage Status

Coverage decreased (-0.01%) to 84.51% when pulling 8710100 on lightswitch05:feature/instant-param into cebf1d6 on dropwizard:master.

@coveralls
Copy link

@coveralls coveralls commented May 8, 2017

Coverage Status

Coverage increased (+0.03%) to 84.551% when pulling ccf006c on lightswitch05:feature/instant-param into cebf1d6 on dropwizard:master.

@lightswitch05
Copy link
Contributor Author

@lightswitch05 lightswitch05 commented May 8, 2017

@joschi I made the requested changes, let me know if it needs more work

joschi
joschi approved these changes May 9, 2017
@joschi joschi merged commit 5e5a5ff into dropwizard:master May 9, 2017
4 checks passed
@joschi
Copy link
Member

@joschi joschi commented May 9, 2017

@lightswitch05 Thanks!

aaanders pushed a commit to aaanders/dropwizard that referenced this issue Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants