Added Java 8 InstantParam with test. #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschi
requested changes
May 8, 2017
| import java.time.ZoneOffset; | ||
| import java.time.LocalDateTime; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Please remove the @author tag (or rather the complete Javadoc comment).
There was a problem hiding this comment.
I missed that one, editor added it automatically.
| /** | ||
| * @author Daniel White | ||
| */ | ||
| public class InstantParamTest { |
There was a problem hiding this comment.
Please add a test case for bad input.
lightswitch05
force-pushed
the
feature/instant-param
branch
from
53d78e5
to
8710100
Compare
lightswitch05
force-pushed
the
feature/instant-param
branch
from
8710100
to
ccf006c
Compare
|
@joschi I made the requested changes, let me know if it needs more work |
joschi
approved these changes
May 9, 2017
|
@lightswitch05 Thanks! |
aaanders
pushed a commit
to aaanders/dropwizard
that referenced
this pull request
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some java 8 users might want to avoid Joda-Time in favor of Instant