New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease allowable tomcat jdbc validation interval to 50ms #2051

Merged
merged 1 commit into from May 10, 2017

Conversation

Projects
None yet
3 participants
@nickbabcock
Contributor

nickbabcock commented May 9, 2017

The minimum should be lowered because it's sensible to allow for
validation intervals of less than a second. For instance, the default
validation interval for HikariCP is 500ms. The lower bound of 50ms
was chosen as a compromise between a nonsensically low number
and 500ms

Decrease allowable tomcat jdbc validation interval to 50ms
The minimum should be lowered because it's sensible to allow for
validation intervals of less than a second. For instance, the default
validation interval for HikariCP is 500ms.

@joschi joschi added this to the 1.2.0 milestone May 10, 2017

@joschi

joschi approved these changes May 10, 2017

@joschi joschi self-assigned this May 10, 2017

@joschi joschi merged commit 76d87f4 into dropwizard:master May 10, 2017

3 of 4 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
codeclimate no new or fixed issues
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@coveralls

This comment has been minimized.

coveralls commented May 10, 2017

Coverage Status

Coverage remained the same at 84.524% when pulling bb41bd3 on nickbabcock:decrease-valid-interval into 5e5a5ff on dropwizard:master.

nickbabcock added a commit that referenced this pull request May 10, 2017

Update release notes for #2051
Also update erroneous PR id

aaanders added a commit to aaanders/dropwizard that referenced this pull request Sep 20, 2018

Decrease allowable tomcat jdbc validation interval to 50ms (dropwizar…
…d#2051)

The minimum should be lowered because it's sensible to allow for
validation intervals of less than a second. For instance, the default
validation interval for HikariCP is 500ms.

aaanders added a commit to aaanders/dropwizard that referenced this pull request Sep 20, 2018

Update release notes for dropwizard#2051
Also update erroneous PR id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment