New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time zone to Java 8 datetime mappers #2069

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
4 participants
@scottaj
Contributor

scottaj commented Jun 6, 2017

Unless I'm missing something this seems like a bug. I ran into it today while playing with JDBI.

Is there a good reason to keep around the default constructor? It looks like it is only used in tests right now. Those could easily pass an empty optional and get the same result, and that would have made this impossible to miss.

@coveralls

This comment has been minimized.

coveralls commented Jun 6, 2017

Coverage Status

Coverage increased (+0.08%) to 84.605% when pulling 59c4d43 on scottaj:add-timezone-to-java-8-types into 428e97a on dropwizard:master.

@jplock jplock added this to the 1.2.0 milestone Jun 7, 2017

@jplock jplock added the bug label Jun 7, 2017

@arteam arteam merged commit 865cafd into dropwizard:master Jun 8, 2017

4 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 84.605%
Details
@arteam

This comment has been minimized.

Member

arteam commented Jun 8, 2017

Looks like so. Thanks for spotting and submitting the pull request.

arteam added a commit that referenced this pull request Jun 8, 2017

arteam added a commit that referenced this pull request Jun 8, 2017

@arteam

This comment has been minimized.

Member

arteam commented Jun 8, 2017

Applied to 1.1.x as c360323

@scottaj scottaj deleted the campspot:add-timezone-to-java-8-types branch Aug 23, 2017

sankate pushed a commit to sankate/dropwizard that referenced this pull request Nov 21, 2017

aaanders added a commit to aaanders/dropwizard that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment