New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client ntlm auth #2091

Merged
merged 7 commits into from Jul 4, 2017

Conversation

Projects
None yet
5 participants
@stringy05
Contributor

stringy05 commented Jun 28, 2017

patch for #2084 to allow a NTCredentials instance to be used for proxy auth. I've also updated the doco, however my ServiceUnavailableRetryStrategy is somewhat unreliable at my work, sometimes it works, sometimes it doesnt

@coveralls

This comment has been minimized.

coveralls commented Jun 28, 2017

Coverage Status

Coverage increased (+0.04%) to 84.972% when pulling 58cab88 on stringy05:client_ntlm_auth into 591af0e on dropwizard:master.

Tidy up style guide issues, remove the ServiceUnavailableRetryStrateg…
…y example in the client manual as it doesn't work
@coveralls

This comment has been minimized.

coveralls commented Jun 28, 2017

Coverage Status

Coverage increased (+0.04%) to 84.972% when pulling 14507d5 on stringy05:client_ntlm_auth into 591af0e on dropwizard:master.

@jplock jplock added this to the 1.2.0 milestone Jun 28, 2017

@jplock jplock added the feature label Jun 28, 2017

@nickbabcock

This comment has been minimized.

Contributor

nickbabcock commented Jun 28, 2017

Thank you for an awesome pull request 🎉

Something that isn't obvious to me is how ServiceUnavailableRetryStrategy is related to NTLM authentication. If not required, it may be prudent to break that into another PR so those changes can be more easily digested and reviewed.

@stringy05

This comment has been minimized.

Contributor

stringy05 commented Jun 29, 2017

stringy05 added some commits Jun 29, 2017

@coveralls

This comment has been minimized.

coveralls commented Jun 29, 2017

Coverage Status

Coverage increased (+0.03%) to 84.96% when pulling 0923c2f on stringy05:client_ntlm_auth into 591af0e on dropwizard:master.

@coveralls

This comment has been minimized.

coveralls commented Jun 29, 2017

Coverage Status

Coverage increased (+0.03%) to 84.96% when pulling 0923c2f on stringy05:client_ntlm_auth into 591af0e on dropwizard:master.

@arteam

This comment has been minimized.

Member

arteam commented Jul 4, 2017

Looks good to me! Thank you very much for this contribution!

@arteam arteam merged commit f7d2cd8 into dropwizard:master Jul 4, 2017

3 of 4 checks passed

codeclimate 1 new issue
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 84.96%
Details

sankate pushed a commit to sankate/dropwizard that referenced this pull request Nov 21, 2017

Client ntlm auth (dropwizard#2091)
* Add support for NTLM proxy authentication

* tidy up doco, add an option to set a service unavailable retry handler

* fix up doco

* fix up the service retry strategy

* Tidy up style guide issues, remove the ServiceUnavailableRetryStrategy example in the client manual as it doesn't work

* Remove the Retry Strategy from this commit

* and fix unused imports

aaanders added a commit to aaanders/dropwizard that referenced this pull request Sep 20, 2018

Client ntlm auth (dropwizard#2091)
* Add support for NTLM proxy authentication

* tidy up doco, add an option to set a service unavailable retry handler

* fix up doco

* fix up the service retry strategy

* Tidy up style guide issues, remove the ServiceUnavailableRetryStrategy example in the client manual as it doesn't work

* Remove the Retry Strategy from this commit

* and fix unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment