New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ServiceUnavailableRetryStrategy #2185

Merged
merged 4 commits into from Oct 26, 2017

Conversation

Projects
None yet
4 participants
@patrox
Contributor

patrox commented Oct 25, 2017

Resolves #2093.

.createClient(apacheBuilder, connectionManager, "test");
assertThat(client).isNotNull();
assertThat(FieldUtils.getField(httpClientBuilderClass,
"serviceUnavailStrategy", true)

This comment has been minimized.

@patrox

patrox Oct 25, 2017

Contributor

This part was quite tricky, as internally it's named quite inconsistently 😢
But I guess this is a punishment for forcing access to the field via reflection 😉

This comment has been minimized.

@arteam

arteam Oct 26, 2017

Member

I am also not a fan of unit tests with Reflection, especially considering most of them will fail on the new builds of Java 9, but in this case it should be good to go. Let's hope Apache Http Client will provide public accessors in future versions.

patrox added some commits Oct 25, 2017

@coveralls

This comment has been minimized.

coveralls commented Oct 26, 2017

Coverage Status

Coverage increased (+0.01%) to 85.496% when pulling 8d91aa2 on patrox:issue_2093_add_service_unavailable_retry_strategy into 9b35878 on dropwizard:master.

@nickbabcock

Expand the glob imports and then LGTM

@patrox

This comment has been minimized.

Contributor

patrox commented Oct 26, 2017

@nickbabcock Yeah, sorry for that, after reinstalling IDEA my old settings disappeared :(
Should be fixed.

@arteam

This comment has been minimized.

Member

arteam commented Oct 26, 2017

@patrox Sorry for nitpicking, but your last commit along with expanding added a lot of other formatting changes. Could you please revert it and just expand the imports?

@arteam arteam added this to the 1.3.0 milestone Oct 26, 2017

@arteam arteam added the feature label Oct 26, 2017

@coveralls

This comment has been minimized.

coveralls commented Oct 26, 2017

Coverage Status

Coverage increased (+0.01%) to 85.496% when pulling c7d6ecb on patrox:issue_2093_add_service_unavailable_retry_strategy into 9b35878 on dropwizard:master.

@patrox

This comment has been minimized.

Contributor

patrox commented Oct 26, 2017

@arteam Sure, sorry I missed that - otherwise I would fix it sooner ! Thanks for the nitpick :)

@patrox patrox force-pushed the patrox:issue_2093_add_service_unavailable_retry_strategy branch from c7d6ecb to 8d91aa2 Oct 26, 2017

@coveralls

This comment has been minimized.

coveralls commented Oct 26, 2017

Coverage Status

Coverage increased (+0.01%) to 85.496% when pulling bcf3e93 on patrox:issue_2093_add_service_unavailable_retry_strategy into d66e51f on dropwizard:master.

@arteam arteam merged commit c67186a into dropwizard:master Oct 26, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 85.496%
Details
@arteam

This comment has been minimized.

Member

arteam commented Oct 26, 2017

LGTM! Thanks @patrox and @nickbabcock!

sankate pushed a commit to sankate/dropwizard that referenced this pull request Nov 21, 2017

Add support for ServiceUnavailableRetryStrategy (dropwizard#2185)
* Add support for ServiceUnavailableRetryStrategy

Resolves dropwizard#2093.

* Remove unused imports

* Remove unused field

* @nickbabcock: expand glob imports

aaanders added a commit to aaanders/dropwizard that referenced this pull request Sep 20, 2018

Add support for ServiceUnavailableRetryStrategy (dropwizard#2185)
* Add support for ServiceUnavailableRetryStrategy

Resolves dropwizard#2093.

* Remove unused imports

* Remove unused field

* @nickbabcock: expand glob imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment