New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deprecated classes from commons-lang to commons-text #2208

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@arteam
Member

arteam commented Nov 13, 2017

Several classes and methods from the commons-lang package like StrSubstitutor and StringUtils.getLevenshteinDistance have been moved to a separate library commons-text. We should follow this deprecation warning and move our dependencies to the new library.

Unfortunately, it's not possible to make this change for the 1.2.1 version, because it changes the public API.

References #2171

Migrate deprecated classes from commons-lang to commons-text
Several classes and methods from the `commons-lang` package
like `StrSubstitutor` and `StringUtils.getLevenshteinDistance` have
been moved to a separate library `commons-text`. We should follow
this deprecation warning and move our dependencies to the new library.

Unfortunately, it's not possible to make this change for the 1.2.1
version, because it changes the public API.

@jplock jplock added the improvement label Nov 13, 2017

@jplock jplock added this to the 1.3.0 milestone Nov 13, 2017

@jplock

jplock approved these changes Nov 13, 2017

@coveralls

This comment has been minimized.

coveralls commented Nov 13, 2017

Coverage Status

Coverage increased (+0.002%) to 87.174% when pulling 1f2228c on migrate-to-commons-text into 502fd32 on master.

@arteam arteam merged commit 8bee1f5 into master Nov 13, 2017

7 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 87.174%
Details

@arteam arteam deleted the migrate-to-commons-text branch Nov 13, 2017

sankate pushed a commit to sankate/dropwizard that referenced this pull request Nov 21, 2017

Migrate deprecated classes from commons-lang to commons-text (dropwiz…
…ard#2208)

Several classes and methods from the `commons-lang` package
like `StrSubstitutor` and `StringUtils.getLevenshteinDistance` have
been moved to a separate library `commons-text`. We should follow
this deprecation warning and move our dependencies to the new library.

Unfortunately, it's not possible to make this change for the 1.2.1
version, because it changes the public API.

aaanders added a commit to aaanders/dropwizard that referenced this pull request Sep 20, 2018

Migrate deprecated classes from commons-lang to commons-text (dropwiz…
…ard#2208)

Several classes and methods from the `commons-lang` package
like `StrSubstitutor` and `StringUtils.getLevenshteinDistance` have
been moved to a separate library `commons-text`. We should follow
this deprecation warning and move our dependencies to the new library.

Unfortunately, it's not possible to make this change for the 1.2.1
version, because it changes the public API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment