New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jadira to 7.0.0-rc1 #2272

Merged
merged 1 commit into from Feb 11, 2018

Conversation

Projects
None yet
2 participants
@arteam
Member

arteam commented Feb 11, 2018

Problem:

We depend on a Jadira fork instead of an official release, because we want to run Dropwizard apps with Hibernate under JDK 9.

Solution:

There has been a new release of Jadira which supports running under JDK 9. That means we can remove a dependency on my fork via jitpack.

This new release also now picks up the database timezone from the hibernate.jdbc.time_zone property, so we should specify it in our tests, otherwise Hibernates reads timestamps in the host's timezone. Theoretically, it can break applications which run databases and application servers in different timezones, but one could argue that such systems should explicitly specify the database timezone. See:

Result:

No 3rd party dependencies in Dropwizard.

Upgrade Jadira to 7.0.0-rc1
There has been a new release of Jadira which supports running under
JDK 9. That means we can remove a dependency on my fork via jitpack.

This new release also now picks up the database timezone from the
`hibernate.jdbc.time_zone` property, so we should specify it in our
tests, otherwise Hibernates reads timestamps in the host's timezone.
@jplock

jplock approved these changes Feb 11, 2018

@jplock jplock added this to the 1.3.0 milestone Feb 11, 2018

@jplock jplock added the improvement label Feb 11, 2018

@jplock jplock merged commit 45864da into master Feb 11, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jplock jplock deleted the upgrade-jadira branch Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment