New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ignoreExceptionOnPreLoadon on PoolProperties configurable #2300

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
2 participants
@oscarnalin
Contributor

oscarnalin commented Mar 9, 2018

Problem:

If Dropwizard starts when the database is down, the application will shutdown. This is caused by org.apache.tomcat.jdbc.pool.ConnectionPool where there is an explicit check on ignoreExceptionOnPreLoadon property. If this is set to "true" Dropwizard will still be able to start without a database present.

Solution:

Make ignoreExceptionOnPreLoadon on PoolProperties configurable

@joschi

joschi approved these changes Mar 9, 2018

LGTM. Thanks! 👍

@joschi joschi merged commit b55fc23 into dropwizard:master Mar 9, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joschi joschi added this to the 1.3.0 milestone Mar 9, 2018

@joschi joschi added the improvement label Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment