Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prerequisites from archetype pom #2320

Merged
merged 1 commit into from Mar 30, 2018

Conversation

Projects
None yet
3 participants
@nickbabcock
Copy link
Contributor

nickbabcock commented Mar 30, 2018

Since Maven 3.5, maven will warn when using <prerequisites>..</prerequisites> for a non maven-plugin project. Since Dropwizard projects are not maven plugins, we remove it from the
archetype pom.

https://maven.apache.org/docs/3.5.0/release-notes.html

Remove prerequisites from archetype pom
Since Maven 3.5, maven will warn when using
`<prerequisites>..</prerequisites>` for a non maven-plugin project.
Since Dropwizard projects are not maven plugins, we remove it from the
archetype pom.

@arteam arteam merged commit 97edef8 into dropwizard:master Mar 30, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arteam

This comment has been minimized.

Copy link
Member

arteam commented Mar 30, 2018

LGTM

@jplock jplock added the improvement label Mar 30, 2018

@jplock jplock added this to the 1.4.0 milestone Mar 30, 2018

@jplock jplock modified the milestones: 1.4.0, 2.0.0 Jun 22, 2018

joschi added a commit that referenced this pull request Feb 3, 2019

Merge pull request #2320 from nickbabcock/remove-prereq-
Remove prerequisites from archetype pom

(cherry picked from commit 97edef8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.