New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jersey attempting to resolve auth filter fields #2324

Merged
merged 1 commit into from Apr 7, 2018

Conversation

Projects
None yet
6 participants
@nickbabcock
Contributor

nickbabcock commented Apr 6, 2018

By removing @Nullable annotation on AuthDynamicFeature fields. In
the process we had to supress null away in the constructor, else that
would fail builds.

Fixes the warning that I and some others have seen in #2307

WARN  [2018-04-06 18:30:49,644] org.glassfish.jersey.internal.Errors: The following warnings have been detected: WARNING: Parameter authFilterClass of type java.lang.Class<? extends javax.ws.rs.container.ContainerRequestFilter> from private final java.lang.Class<? extends javax.ws.rs.container.ContainerRequestFilter> io.dropwizard.auth.AuthDynamicFeature.authFilterClass is not resolvable to a concrete type.
WARNING: Parameter authFilterClass of type java.lang.Class<? extends javax.ws.rs.container.ContainerRequestFilter> from private final java.lang.Class<? extends javax.ws.rs.container.ContainerRequestFilter> io.dropwizard.auth.AuthDynamicFeature.authFilterClass is not resolvable to a concrete type.

Still unresolved:

  • Why is this happening now (Dropwizard 1.3)? Seems entirely Jersey related but we haven't bumped Jersey versions in quite some time.
  • Doesn't fix the issue seen in OP in #2307 revolving around Kotlin resource class.
Fix jersey attempting to resolve auth filter fields
By removing `@nullable` annotation on `AuthDynamicFeature` fields. In
the process we had to supress null away in the constructor, else that
would fail builds.

@jplock jplock added the bug label Apr 7, 2018

@jplock jplock added this to the 1.4.0 milestone Apr 7, 2018

@jplock

jplock approved these changes Apr 7, 2018

@jplock jplock merged commit 1fb4167 into dropwizard:master Apr 7, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@isaki

This comment has been minimized.

Contributor

isaki commented Apr 16, 2018

Will there be a 1.3.2 release to pick up this change?

@glfp

This comment has been minimized.

glfp commented May 24, 2018

+1 also with Java 10

@arteam

This comment has been minimized.

Member

arteam commented May 24, 2018

I will to a 1.3.3 release this week with this change.

@gjesse

This comment has been minimized.

gjesse commented Jun 6, 2018

Is the 1.3.3 release still coming soon with this fix?

@glfp

This comment has been minimized.

glfp commented Jun 6, 2018

+1

@arteam

This comment has been minimized.

Member

arteam commented Jun 6, 2018

Sorry guys, I've been busy the past few weeks with other stuff. Thanks for the reminder, I will do a release today or tomorrow.

@arteam

This comment has been minimized.

Member

arteam commented Jun 6, 2018

I've released Dropwizard 1.3.3 https://github.com/dropwizard/dropwizard/releases/tag/v1.3.3. Should be available in Maven Central in a couple of hours.

@glfp

This comment has been minimized.

glfp commented Jun 7, 2018

Thanks ! Tested, now works well !

@jplock jplock modified the milestones: 1.4.0, 2.0.0 Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment