New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Liquibase from 3.5.5 to 3.6.0, to be compatible with Jdk10. #2325

Merged
merged 1 commit into from Apr 7, 2018

Conversation

Projects
None yet
3 participants
@xiaodong-xie
Contributor

xiaodong-xie commented Apr 6, 2018

Problem:

Liquibase 3.5.5 cannot run on Jdk10, due to its JDK version check failure. The issue was fixed in 3.6.0.

Solution:

Bump up version of Liquibase from 3.5.5 to newest 3.6.0.

Result:

Dropwizard could run on Jdk10.

@nickbabcock

This comment has been minimized.

Contributor

nickbabcock commented Apr 6, 2018

Oh how exciting, this would fix #1708 too

@xiaodong-xie

This comment has been minimized.

Contributor

xiaodong-xie commented Apr 6, 2018

I'll look into those test failures...

@jplock jplock added this to the 1.4.0 milestone Apr 7, 2018

@jplock jplock added the improvement label Apr 7, 2018

@xiaodong-xie

This comment has been minimized.

Contributor

xiaodong-xie commented Apr 7, 2018

liquibase/liquibase@9acf2fb#diff-df4fa5e5aa8d525d2a3caaaa237ec2df

Liquibase updated CHECKSUM_ALGORITHM from 7 to 8.

@xiaodong-xie xiaodong-xie force-pushed the xiaodong-xie:upgrade-liquibase branch from d2f7df2 to 75d1557 Apr 7, 2018

@xiaodong-xie

This comment has been minimized.

Contributor

xiaodong-xie commented Apr 7, 2018

Changed contents in test-db.mv.db file, due to the CHECKSUM_ALGORITHM change in Liquibase.

7:0f9e4aa31e065bbdffa9eb3ead0ae2c8 -> 8:b0ec2153e830053427f3182dfa7ae6dd
7:3a61a7a72c9ce082b7059215975e6e09 -> 8:0f3683b37321ccfb1694a044986de4d9
7:aad8d260150f46b5a4663fc4b2a80474 -> 8:d3ff16527dcfc0c86495d15619027d5e

@xiaodong-xie xiaodong-xie force-pushed the xiaodong-xie:upgrade-liquibase branch 3 times, most recently from e8e327c to 865a0c5 Apr 7, 2018

@xiaodong-xie xiaodong-xie force-pushed the xiaodong-xie:upgrade-liquibase branch from 865a0c5 to fe842d2 Apr 7, 2018

@@ -10,6 +12,7 @@

static {
ArgumentParsers.setTerminalWidthDetection(false);
SqlGeneratorFactory.getInstance().unregister(AddColumnGeneratorSQLite.class);

This comment has been minimized.

@xiaodong-xie

xiaodong-xie Apr 7, 2018

Contributor

Created a PR against Liquibase liquibase/liquibase#756. Before the bug is fixed, we have to add this workaround.

@xiaodong-xie

This comment has been minimized.

Contributor

xiaodong-xie commented Apr 7, 2018

Ping @jplock, finally I made the build pass. 😄

@jplock

jplock approved these changes Apr 7, 2018

@jplock jplock merged commit 02098f7 into dropwizard:master Apr 7, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jplock

This comment has been minimized.

Member

jplock commented Apr 7, 2018

Thanks!

@xiaodong-xie

This comment has been minimized.

Contributor

xiaodong-xie commented Apr 7, 2018

Thanks for merging, @jplock. 👍 😄

@xiaodong-xie xiaodong-xie deleted the xiaodong-xie:upgrade-liquibase branch Apr 7, 2018

@jplock jplock modified the milestones: 1.4.0, 2.0.0 Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment