New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JUnit5 5.2.0 #2347

Merged
merged 2 commits into from May 27, 2018

Conversation

Projects
None yet
3 participants
@arteam
Member

arteam commented May 6, 2018

Problem:

We use an outdated version of JUnit 5 dependencies.

Solution:

Upgrade the JUnit5 dependencies and maven-surefire-plugin to the latest versions.

Result:

It adds some new features for parametrized tests and provides better Java 9/10 comparability. Suprisingly enough, we used a very old version of junit-vintage-engine

@arteam arteam force-pushed the junit-5-upgrade branch from 5144cc4 to d70e2e9 May 24, 2018

Upgrade to JUnit5 5.2.0
It adds some new features for parametrized tests and provides better
Java 9/10 comparability.

Suprisingly enough, we used a very old version of `junit-vintage-engine`

@arteam arteam force-pushed the junit-5-upgrade branch from d70e2e9 to 040444a May 24, 2018

Run tests with the original junit not junit-vintage
JUnit-vintage breaks on JDK10 on with JUnit 5.2.0.

@arteam arteam merged commit 17c1687 into master May 27, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@arteam arteam deleted the junit-5-upgrade branch May 27, 2018

arteam added a commit that referenced this pull request May 27, 2018

Upgrade to JUnit5 5.2.0 (#2347)
* Upgrade to JUnit5 5.2.0

It adds some new features for parametrized tests and provides better
Java 9/10 comparability.

Suprisingly enough, we used a very old version of `junit-vintage-engine`

* Run tests with the original junit not junit-vintage

JUnit-vintage breaks on JDK10 on with JUnit 5.2.0.

@jplock jplock added this to the 1.4.0 milestone Jun 15, 2018

@jplock jplock added the improvement label Jun 15, 2018

@jplock jplock modified the milestones: 1.4.0, 2.0.0 Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment