Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document TeeFilter for json log format #2596

Merged
merged 1 commit into from Jan 10, 2019
Merged

Document TeeFilter for json log format #2596

merged 1 commit into from Jan 10, 2019

Conversation

nickbabcock
Copy link
Contributor

Problem:

Not clear from our docs that in order to use responseContent or requestContent in json logging that TeeFilter must be registered

Solution:

Link to the official logback site for TeeFilter and show a comment of one being registered

Result:

Hopefully the docs are more clear.

@nickbabcock nickbabcock mentioned this pull request Jan 10, 2019
Closed
joschi
joschi approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joschi joschi merged commit 7185703 into dropwizard:master Jan 10, 2019
@joschi joschi added this to the 2.0.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickbabcock @joschi