Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE if /admin/tasks is requested. Now it returns a 404 (#2626) #2627

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@hheg
Copy link
Contributor

hheg commented Feb 3, 2019

Problem:

There's a NPE when asking for /admin/tasks.

Solution:

Check the request.getPathInfo() return value before passing it to the map. HttpServletRequest.getPathInfo() will return null if there's no path information.

Result:

Instead of a 500 response it will return a 404

@joschi

joschi approved these changes Feb 3, 2019

Copy link
Member

joschi left a comment

LGTM. Thanks!

@joschi joschi merged commit dc9b385 into dropwizard:master Feb 3, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joschi joschi added the bug label Feb 3, 2019

@joschi joschi added this to the 2.0.0 milestone Feb 3, 2019

joschi added a commit that referenced this pull request Feb 3, 2019

Return 404 for POST /admin/tasks (#2627)
Fixes #2626

(cherry picked from commit dc9b385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.