Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Jackson Afterburner only on Java 8 (backport) #3028

Merged
merged 3 commits into from Nov 24, 2019

Conversation

@pedsm
Copy link

pedsm commented Nov 18, 2019

This MR is to backport the fixes made on b1c3957 to release/1.3.x

Problem:

The Jackson Afterburner module is currently not compatible with the JPMS and will lead to illegal reflective access operation warnings:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.fasterxml.jackson.module.afterburner.util.MyClassLoader (file:.m2/repository/com/fasterxml/jackson/module/jackson-module-afterburner/2.9.9/jackson-module-afterburner-2.9.9.jar) to method java.lang.ClassLoader.findLoadedClass(java.lang.String)
WARNING: Please consider reporting this to the maintainers of com.fasterxml.jackson.module.afterburner.util.MyClassLoader
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Fixes #2909
Refs #2966
Refs FasterXML/jackson-modules-base#37

Solution:

Cherry-pick the commit into the release/1.3.x branch to be included on the next release

Result:

This will allow the fix to be used on a stable version of dropwizard. As of now, the fix is only available through the 2.0 Release candidate

The Jackson Afterburner module is currently not compatible with the JPMS and will lead to illegal reflective access operation warnings:
```
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.fasterxml.jackson.module.afterburner.util.MyClassLoader (file:.m2/repository/com/fasterxml/jackson/module/jackson-module-afterburner/2.9.9/jackson-module-afterburner-2.9.9.jar) to method java.lang.ClassLoader.findLoadedClass(java.lang.String)
WARNING: Please consider reporting this to the maintainers of com.fasterxml.jackson.module.afterburner.util.MyClassLoader
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
```

Fixes #2909
Refs FasterXML/jackson-modules-base#37
Backport changes from 877b566
@pedsm pedsm force-pushed the pedsm:release/1.3.x branch from 8cb4baf to 45706b1 Nov 19, 2019
dropwizard-util/pom.xml Outdated Show resolved Hide resolved
@joschi joschi changed the title Backport changes from #2966 Enable Jackson Afterburner only on Java 8 (backport) Nov 24, 2019
@joschi joschi added this to the 1.3.17 milestone Nov 24, 2019
@joschi joschi self-assigned this Nov 24, 2019
Test methods have to be public with JUnit 4.x.
@joschi
joschi approved these changes Nov 24, 2019
@joschi joschi merged commit dbc17eb into dropwizard:release/1.3.x Nov 24, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.