Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Apache httpclient to 4.5.10 to fix URI rewriting #3029

Merged
merged 1 commit into from Nov 24, 2019

Conversation

@MatthewRyanRead
Copy link

MatthewRyanRead commented Nov 20, 2019

See https://issues.apache.org/jira/browse/HTTPCLIENT-1968 for detailed background.

Problem:

4.5.7 introduced a change to normalize URIs by removing repeated forward slashes. However, this broke encoded reserved characters in the URI, such as the forward slash itself (%2F). I've been running into this while using the latest Dropwizard 1.3 release.

Example URI that fails: http://localhost/math/1%2F2 (gets converted to http://localhost/math/1/2 prior to the request being made)

Solution:

4.5.8 fixed this issue, but .9 and .10 included good fixes as well, so bump up to 4.5.10.

Result:

See the release notes for the list of fixes: https://github.com/apache/httpcomponents-client/blob/4.5.10/RELEASE_NOTES.txt

@joschi joschi added this to the 1.3.17 milestone Nov 24, 2019
@joschi

This comment has been minimized.

Copy link
Member

joschi commented Nov 24, 2019

@MatthewRyanRead Thank you for your contribution!

@joschi joschi merged commit 7b366c9 into dropwizard:release/1.3.x Nov 24, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joschi joschi self-assigned this Nov 24, 2019
@MatthewRyanRead MatthewRyanRead deleted the MatthewRyanRead:patch-2 branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.