New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Optional @FormParam injectable. #677

Merged
merged 3 commits into from Aug 17, 2014

Conversation

Projects
None yet
2 participants
@krismassey

krismassey commented Aug 8, 2014

Adding the ability to wrap a @FormParam resource parameter in a Guava Optional.

The behaviour mimics that of the Optional wrapper for the @QueryParam.

There are also some very minor code improvements removing unneeded imports and a rouge semicolon.

@joschi

This comment has been minimized.

Member

joschi commented Aug 17, 2014

Looks good to me. Although we plan to migrate to Jersey 2.x in Dropwizard 0.8.0, it might be useful if we decide to do another intermediate 0.7.x release. Thanks!

joschi added a commit that referenced this pull request Aug 17, 2014

Merge pull request #677 from krismassey/optional-form-param
Adding Optional @FormParam injectable.

@joschi joschi merged commit 2b539ac into dropwizard:master Aug 17, 2014

@joschi joschi added the feature label Aug 17, 2014

@krismassey krismassey deleted the krismassey:optional-form-param branch Aug 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment