New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging (on TRACE) for failed validation of Jackson data. #992

Merged
merged 2 commits into from Apr 15, 2015

Conversation

Projects
None yet
4 participants
@piefel

piefel commented Apr 14, 2015

As discussed on https://groups.google.com/forum/#!topic/dropwizard-user/FQd_Y4ihb7I, I have prepared a little patch that will print the failed validation alongside the object that was validated, on TRACE only.

@@ -29,6 +31,7 @@
* {@link JsonIgnoreType}.)
*/
public class JacksonMessageBodyProvider extends JacksonJaxbJsonProvider {
private static final Logger LOGGER = LoggerFactory.getLogger(JsonProcessingExceptionMapper.class);

This comment has been minimized.

@jplock

jplock Apr 14, 2015

Member

Can this be updated to JacksonMessageBodyProvider to reflect the class its in?

This comment has been minimized.

@piefel

piefel Apr 14, 2015

Yes, of course, a typical Copy & Paste error. What’s the procedure now? I’m new to this. Shall I fix it and create a new pull request, or will someone manually fix it after the merge?

This comment has been minimized.

@jplock

jplock Apr 14, 2015

Member

Can you commit the fix and push it back to your piefel:validationLogging branch? Then it should show up in this PR automatically.

carlo-rtr added a commit that referenced this pull request Apr 15, 2015

Merge pull request #992 from piefel/validationLogging
Add logging (on TRACE) for failed validation of Jackson data.

@carlo-rtr carlo-rtr merged commit ba3f3b3 into dropwizard:master Apr 15, 2015

@jplock jplock added this to the 0.9.0 milestone Apr 15, 2015

@piefel piefel deleted the piefel:validationLogging branch Apr 21, 2015

@arteam arteam added the improvement label Apr 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment