Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reporters more user friendly for managed environments like GAE or JEE #1018

Merged
merged 1 commit into from Jan 5, 2017

Conversation

@vladimir-bukhtoyarov
Copy link
Contributor

@vladimir-bukhtoyarov vladimir-bukhtoyarov commented Oct 29, 2016

Added two configuration options for all reporters:

  1. Ability to configure the custom scheduler. This Is very useful option when instantiation of new Thread is problematic.
  2. Option which allow to avoid termination the executor which is managed by external resource container(like JEE server).

This request also closes issue #968

…r JEE:

1.  Ability to configure the custom scheduler. This Is very useful option when instantiation of new Thread is problematic.
2. Option which allow to avoid termination the executor which is managed by external resource container(like JEE server).
@svendiedrichsen
Copy link

@svendiedrichsen svendiedrichsen commented Nov 8, 2016

I would like to vote for this to go into the next release. Helps saving resources a lot in the specified environments.

@vladimir-bukhtoyarov
Copy link
Contributor Author

@vladimir-bukhtoyarov vladimir-bukhtoyarov commented Nov 8, 2016

@svendiedrichsen What I need to do with current request? Should I rebase it to another branch?

@svendiedrichsen
Copy link

@svendiedrichsen svendiedrichsen commented Nov 9, 2016

I have no saying on wether this change gets pulled. I just happen to like it and support it.

@arteam arteam merged commit 3c369cd into dropwizard:3.2-development Jan 5, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arteam
Copy link
Member

@arteam arteam commented Jan 5, 2017

@vladimir-bukhtoyarov, Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.