New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Add `getProtocols` method" #1038

Merged
merged 2 commits into from Jan 5, 2017

Conversation

Projects
None yet
2 participants
@arteam
Member

arteam commented Jan 5, 2017

This method is declared in ConnectionFactory in Jetty 9.3.*.
To be compatible with it, we should have a method with the same
signature.

We can't use a compile-time dependency on Jetty 9.3.*, because
it's compiled against Java 8, but codahale-metrics against Java 6.

Therefore, we use reflection to access this method.

Backport of #823

arteam added some commits Jan 5, 2017

Add `getProtocols` method
This method is declared in ConnectionFactory in Jetty 9.3.*.
To be compatible with it, we should have a method with the same
signature.

We can't use a compile-time dependency on Jetty 9.3.*, because
it's compiled against Java 8, but codahale-metrics against Java 6.

Therefore, we use reflection to access this method.

Backport of #823

@arteam arteam referenced this pull request Jan 5, 2017

Merged

Add `getProtocols` method #1037

@arteam arteam merged commit 3816803 into 3.2-development Jan 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@arteam arteam deleted the revert-1037-jetty_93_metrics_32 branch Jan 5, 2017

@arteam arteam added the improvement label Jan 5, 2017

@arteam arteam added this to the 3.2.0 milestone Jan 5, 2017

@arteam arteam referenced this pull request Jan 5, 2017

Closed

Is Jetty 9.3 supported? #980

@marsmining

This comment has been minimized.

Show comment
Hide comment
@marsmining

marsmining Jan 22, 2017

Thanks for this work! Any idea when this will land in a release?

marsmining commented Jan 22, 2017

Thanks for this work! Any idea when this will land in a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment