New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to disable attributes in ConsoleReporter to be consistent… #1092

Merged
merged 3 commits into from Feb 28, 2017

Conversation

Projects
None yet
3 participants
@husseincoder
Contributor

husseincoder commented Feb 25, 2017

Add support to disable attributes in console reporter to be consistent with GraphiteReporter features .. I saw its easy to be implemented there with not so many changes

@arteam

Thank you for working on this! I didn't add filtering attributes to ConsoleReporter, because it's mostly used for debug purposes. But I guess there is no reason not to implement it in a backward-compatible manner. I've added a couple of comments, which need to be addressed, before merging.

@husseincoder

This comment has been minimized.

Show comment
Hide comment
@husseincoder

husseincoder Feb 27, 2017

Contributor

@arteam Thanks for the code review .. I've changed these stuff and gonna push them soon

Contributor

husseincoder commented Feb 27, 2017

@arteam Thanks for the code review .. I've changed these stuff and gonna push them soon

@jplock jplock added this to the 3.2.1 milestone Feb 27, 2017

@jplock jplock added the improvement label Feb 27, 2017

@arteam arteam merged commit d170988 into dropwizard:3.2-development Feb 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arteam

This comment has been minimized.

Show comment
Hide comment
@arteam

arteam Feb 28, 2017

Member

Thanks for your hard work on this, looks great!

Member

arteam commented Feb 28, 2017

Thanks for your hard work on this, looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment